AdminSocketAnalytics.js: Remove duplicated code #10574
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
sgothel
force-pushed
the
private/sgothel/admin_conn_activity_cleanup
branch
from
9dd9484 to
d70172c
Compare
|
rebased to master (conflicts) |
…ext processing into Util.consumeDataText Signed-off-by: Sven Göthel <[email protected]> Change-Id: I65126d65ae2f43efaeefb8091385a405bd2544e0
|
omg, looks like very good cleanup :) I will rebase |
eszkadev
force-pushed
the
private/sgothel/admin_conn_activity_cleanup
branch
from
d70172c to
024fed1
Compare
|
@Rash419 could you check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I65126d65ae2f43efaeefb8091385a405bd2544e0
Summary
Refines PR #10456 by removing duplicate code, factoring out data text processing into Util.consumeDataText.
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay