Treeview control changes #10877
Open
Treeview control changes #10877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hcvcastro
force-pushed
the
pr/master/98
branch
from
9e8fe4d to
f93e4e9
Compare
eszkadev
reviewed
Jan 9, 2025
| } | ||
|
|
||
| get Container() { | ||
| return this._container; | ||
| } | ||
|
|
||
| static getTreeView(e: any) { |
There was a problem hiding this comment.
why do we need this static?
isn't better to just work on current instance?
There was a problem hiding this comment.
good point, yes, I think it is not needed the static. Thanks.
hcvcastro
force-pushed
the
pr/master/98
branch
3 times, most recently
from
7efff23 to
4128eb2
Compare
eszkadev
reviewed
Jan 9, 2025
| } | ||
|
|
||
| onCheckBoxClick(checkbox: any) { | ||
| if (checkbox.checked) { |
There was a problem hiding this comment.
what if is disabled? shouldn't do anything then
if (L.DomUtil.hasClass(row, 'disabled'))
There was a problem hiding this comment.
I know, I am still drafting to equivalent code. Thanks for the notice
Change-Id: Icf084135e9c743d84522b4bc9f09925300363af2 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I60a7d132b5d7bec238b01c02a8833ba08eb36e7e Signed-off-by: Henry Castro <[email protected]>
Change-Id: Ib4c5c2770cbbdb9f56d5219599142893ed0c05c9 Signed-off-by: Henry Castro <[email protected]>
Implicit query checkbox. Change-Id: I01cbf3b6a49babdd594fd481c1785dd7677f6bed Signed-off-by: Henry Castro <[email protected]>
Change-Id: I7299b4efd3ec09f6c14324ad9cbf5dbda82f5104 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I84fcd3eca4aa34f73a8ef3feb613d81266358b14 Signed-off-by: Henry Castro <[email protected]>
Change-Id: I4d367cf704cd784af290969526009df4884d01d4 Signed-off-by: Henry Castro <[email protected]>
hcvcastro
force-pushed
the
pr/master/98
branch
from
4128eb2 to
e86ace6
Compare
Change-Id: Ied04405a87e8d9b5d45d192f4f244262b2fdc9a7 Signed-off-by: Henry Castro <[email protected]>
hcvcastro
force-pushed
the
pr/master/98
branch
from
e86ace6 to
08a0144
Compare
Change-Id: I92811506d7f71a807f6f747a959eb8636ef3030a Signed-off-by: Henry Castro <[email protected]>
Change-Id: I4e800b4b36d2536991c05c54511c94203da3971f Signed-off-by: Henry Castro <[email protected]>
Change-Id: I7f09dc79641da4ede273de3cccce3125a52fff69 Signed-off-by: Henry Castro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Icf084135e9c743d84522b4bc9f09925300363af2
Signed-off-by: Henry Castro [email protected]
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay