Improved autosaved state for comments

[rparth07]

Change-Id: I9ad6c36a393ef5d895ee463f44569c52f1c8fd61

• Resolves: Improve autosaved state for comments #7211
• Target version: master

Checklist

• Code is properly formatted
• All commits have Change-Id
• I have run tests with make check
• I have issued make run and manually verified that everything looks okay
• Documentation (manuals or wiki) has been updated or is not required

[pedropintosilva]

Thanks @rparth07

it seems that now the comment (edit mode) is visible for other users

and I also get when opening the same document and trying to comment in two different browsers

17:41:10.008 Uncaught TypeError: this._viewInfo[viewid] is undefined
    getViewName Map.js:872
    insertComment CommentListSection.ts:8
    _insertAnnotationControl Control.NotebookbarBuilder.js:936
    jQuery 2
6 Map.js:872:2

Also it the user comes back and doesn't press any button and clicks in another part of the document -> it's then impossible to edit the comment

[rparth07]

it seems that now the comment (edit mode) is visible for other users

Sure, let's clarify the intended behavior. If I understand correctly, you're suggesting that the comment in edit mode should not be visible to other users once the focus is lost. Is that the expected behavior we aim for?

and I also get when opening the same document and trying to comment in two different browsers

17:41:10.008 Uncaught TypeError: this._viewInfo[viewid] is undefined
    getViewName Map.js:872
    insertComment CommentListSection.ts:8
    _insertAnnotationControl Control.NotebookbarBuilder.js:936
    jQuery 2
6 Map.js:872:2

I couldn't replicate the error on my end. Could you please provide detailed steps to reproduce the issue? Additionally, are there specific browsers where this problem occurs?

Also it the user comes back and doesn't press any button and clicks in another part of the document -> it's then impossible to edit the comment

The described behavior does sound unusual. Could you please provide more details on this issue? Also, do you think this behavior is related to the error mentioned earlier?

Any insights you can share will help me in thoroughly understanding and resolving this. Thank you for your assistance @pedropintosilva .

[eszkadev]

@rparth07 hi, are you still working on this PR? :) It requires rebase as we have conflicts with newer commits.

Would be good to put few sentences into commit message:

• what issue does it fix?
• how to test that it is fixed?

@lpranam could help here as he knows best the comments and autosave

[Darshan-upadhyay1110]

@rparth07 can you please rebase and solve the conflicts here ?

[rparth07]

Thanks @eszkadev @Darshan-upadhyay1110 will do:)

[lpranam]

Merge commits are not allowed...

[rparth07]

Merge commits are not allowed...

sorry, It was by mistake!

[rparth07]

I resolved the merge conflicts and updated the relevant test cases for autosaved comments. However, in the multi-user Cypress tests, three test cases related to reply autosave are currently failing.

Upon further investigation, I found a potential issue (#10429) that may be causing these test failures. I believe that addressing this issue will likely resolve the failing test cases.

[eszkadev]

Tests are now passing. @rparth07 will you have some time to update this PR and rebase on top of master?

[rparth07]

Tests are now passing. @rparth07 will you have some time to update this PR and rebase on top of master?

Sure, will do it by today.

[eszkadev]

please rebase, we have API change again...

[eszkadev]

this can have conflicts with #10772
let's wait for the other to be merged first as tests here are not passing it seems

[eszkadev]

oh @rparth07 thanks for rebasing last week, I think we had CI broken. Could you try again next qweek? maybe we will merge it finally :)

[eszkadev]

@lpranam could you review as you know the comments auto-save code? :)

[lpranam]

Rest of the code looks good. except my one small comment. also maybe run make prettier-write to solve the issue meven pointed.