Skip to content

test(compiler): browser targets #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 5, 2025
Merged

Conversation

BioPhoton
Copy link
Collaborator

@BioPhoton BioPhoton commented Feb 28, 2025

This PR includes:

  • introduce testing-setup lib to not repeat configuration
  • unit tests for compiler
  • exclude config files etc form coverage report

Note:
I had to hack in a dependency. Maybe you can suggest a better way.

@github-actions github-actions bot added 🧩 compiler Compiler project 🛠️ tooling 📖 documentation 🧪 testing Tests, mocks and configuration labels Feb 28, 2025
Copy link

nx-cloud bot commented Feb 28, 2025

View your CI Pipeline Execution ↗ for commit e7d83b6.

Command Status Duration Result
nx-cloud record -- pnpm check-commit ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-03 12:38:38 UTC

Copy link

github-actions bot commented Feb 28, 2025

Code PushUp

🤨 Code PushUp report has both improvements and regressions – compared current commit 2523eba with previous commit c826b7a.

💼 Project compiler

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 81 🟡 83 ↑ +2.3

2 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 81 🟡 83 ↑ +2.3

3 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟨 74.1 % 🟨 81.3 % ↑ +9.8 %
Code coverage Branch coverage 🟨 69.6 % 🟨 75 % ↑ +7.7 %

137 other audits are unchanged.

💼 Project build

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 72 🟡 73 ↑ +1.7

2 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 72 🟡 73 ↑ +1.7

3 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟥 36.7 % 🟥 42.3 % ↑ +15.4 %
Code coverage Line coverage 🟥 6 % 🟥 6.5 % ↑ +8 %

136 other audits are unchanged.

💼 Project nx-plugin

🥳 Code PushUp report has improved.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🔴 39 🔴 40 ↑ +1

2 other categories are unchanged.

👍 1 group improved, 👍 2 audits improved

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🔴 39 🔴 40 ↑ +1

3 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Branch coverage 🟥 26.7 % 🟥 29.6 % ↑ +11.1 %
Code coverage Line coverage 🟥 13 % 🟥 14.3 % ↑ +10 %

138 other audits are unchanged.

💼 Project rsbuild-plugin-angular

🤨 Code PushUp report has both improvements and regressions.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 51 🟡 51 ↑ +0.2

2 other categories are unchanged.

👍 1 group improved, 👍 1 audit improved, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 51 🟡 51 ↑ +0.2

3 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟥 32.3 % 🟥 29.5 % ↓ −8.7 %
Code coverage Branch coverage 🟨 66.7 % 🟨 68.4 % ↑ +2.6 %

137 other audits are unchanged.


1 other project is unchanged.

@BioPhoton BioPhoton requested a review from Coly010 March 1, 2025 16:26
@BioPhoton BioPhoton marked this pull request as ready for review March 1, 2025 16:27
@Coly010 Coly010 merged commit 24aeb9c into main Mar 5, 2025
5 checks passed
@Coly010 Coly010 deleted the test/compiler/browser-targets branch March 5, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 compiler Compiler project 📖 documentation 🧪 testing Tests, mocks and configuration 🛠️ tooling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants