Skip to content

feat(build,rsbuild-plugin-angular): add support for incremental hydration #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 3, 2025

Conversation

Coly010
Copy link
Owner

@Coly010 Coly010 commented Mar 1, 2025

  • feat(build): add incremental hydration support
  • feat(rsbuild-plugin-angular): add support for incremental hydration

Ensure the ng-event-dispatch-contract script tag is added to the html at build time.

This allows @angular/platform-server to find it correctly when trying to add the script tag of events for jsAction to listen for.

@Coly010 Coly010 self-assigned this Mar 1, 2025
@github-actions github-actions bot added 🧩 build Build project 🧩 rsbuild-plugin-angular Rsbuild Plugin Angular project 📖 documentation labels Mar 1, 2025
Copy link

nx-cloud bot commented Mar 1, 2025

View your CI Pipeline Execution ↗ for commit b1a40e6.

Command Status Duration Result
nx affected -t lint build unit-test integration... ✅ Succeeded 2m 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-03 07:08:25 UTC

Copy link

github-actions bot commented Mar 1, 2025

Code PushUp

😟 Code PushUp report has regressed – compared current commit 7c5d2ce with previous commit c826b7a.

💼 Project rsbuild-plugin-angular

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 51 🟡 51 ↓ −0.1

2 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 51 🟡 51 ↓ −0.1

3 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟥 32.3 % 🟥 31.8 % ↓ −1.4 %

137 other audits are unchanged.

💼 Project build

😟 Code PushUp report has regressed.

🕵️ See full comparison in Code PushUp portal 🔍

🏷️ Category ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage 🟡 72 🟡 72 ↓ −0.1

2 other categories are unchanged.

👎 1 group regressed, 👎 1 audit regressed

🗃️ Groups

🔌 Plugin 🗃️ Group ⭐ Previous score ⭐ Current score 🔄 Score change
Code coverage Code coverage metrics 🟡 72 🟡 72 ↓ −0.1

3 other groups are unchanged.

🛡️ Audits

🔌 Plugin 🛡️ Audit 📏 Previous value 📏 Current value 🔄 Value change
Code coverage Line coverage 🟥 6 % 🟥 6 % ↓ −1 %

138 other audits are unchanged.


3 other projects are unchanged.

@Coly010 Coly010 force-pushed the incremental-hydration-support branch from 1b451f6 to b1a40e6 Compare March 2, 2025 19:41
@Coly010 Coly010 merged commit 1b7d331 into main Mar 3, 2025
6 checks passed
@Coly010 Coly010 deleted the incremental-hydration-support branch March 3, 2025 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧩 build Build project 📖 documentation 🧩 rsbuild-plugin-angular Rsbuild Plugin Angular project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant