-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Uvicorn Integration #219
Conversation
src/Aspire.CommunityToolkit.Hosting.Uvicorn/CommunityToolkit.Aspire.Hosting.Uvicorn.csproj
Outdated
Show resolved
Hide resolved
…spire.Hosting.Uvicorn.csproj Co-authored-by: Alireza Baloochi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's your thought on rather than this being a standalone Uvicorn
hosting package, that we make it an extensions package like the Node.js one in the repo that adds Uvicorn?
This would mean that if we want to add additional things, like venv setup, pip installation, other Python runtimes, etc., they don't have to be in their own hosting packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we integrate OTEL into here to show how you can do that end-to-end tracing
src/Aspire.CommunityToolkit.Hosting.Uvicorn/CommunityToolkit.Aspire.Hosting.Uvicorn.csproj
Outdated
Show resolved
Hide resolved
src/Aspire.CommunityToolkit.Hosting.Uvicorn/Utils/PathNormalizer.cs
Outdated
Show resolved
Hide resolved
src/Aspire.CommunityToolkit.Hosting.Uvicorn/UvicornAppHostingExtension.cs
Outdated
Show resolved
Hide resolved
src/Aspire.CommunityToolkit.Hosting.Uvicorn/UvicornAppResource.cs
Outdated
Show resolved
Hide resolved
tests/CommunityToolkit.Aspire.Hosting.Uvicorn.Tests/ResourceCreationTests.cs
Outdated
Show resolved
Hide resolved
…spire.Hosting.Uvicorn.csproj Co-authored-by: Aaron Powell <[email protected]>
…xtension.cs Co-authored-by: Aaron Powell <[email protected]>
I agree. Maybe we should structure this as we did with NodeJS Extensions. Especially considering we also have this #221 |
That's exactly where my thinking was going 😉 |
This will make it easier to add the features of #221
src/CommunityToolkit.Aspire.Hosting.Python.Extensions/README.md
Outdated
Show resolved
Hide resolved
src/CommunityToolkit.Aspire.Hosting.Python.Extensions/README.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of small docs tweeks @tommasodotNET
But make sure you review the moving around of files and everything
@tommasodotNET I'm working on using the |
Co-authored-by: Aaron Powell <[email protected]>
Co-authored-by: Aaron Powell <[email protected]>
Minimum allowed line rate is |
**Closes #207 *
Adds Uvicorn integration. The logic is the same as for official Python integration but it uses uvicorn to run the app.
PR Checklist