feat: Enable Grid to dynamically switch layouts #4474
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks nandin-borjigin for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
ghost
requested review from
11 tasks
5 tasks
XAML-Knight
suggested changes
Feb 2, 2022
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridExtensions/GridExtensionsPage.xaml
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridExtensions/GridExtensionsPage.xaml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridExtensions/GridExtensionsPage.xaml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI/Extensions/Grid/GridLayoutDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridExtensions/GridExtensionsPage.xaml
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI/Extensions/Grid/GridLayoutDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI/Extensions/Grid/GridLayoutDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.UI/Extensions/Grid/GridLayoutDefinition.cs
Outdated
Show resolved
Hide resolved
Microsoft.Toolkit.Uwp.SampleApp/SamplePages/GridExtensions/GridExtensionsCode.bind
Outdated
Show resolved
Hide resolved
ghost
added
the
Co-authored-by: XAML-Knight <[email protected]>
|
This PR has been marked as "needs attention 👋" and awaiting a response from the team. |
XAML-Knight
approved these changes
Feb 3, 2022
michael-hawker
added
extensions ⚡
feature 💡
labs 🧪
Arlodotexe
reviewed
Feb 8, 2022
| /// This usage is not really invalid (it does not throw), | ||
| /// but this API is not expected to be used like this. | ||
| /// </example> | ||
| public string AreaDefinition |
There was a problem hiding this comment.
Do we maybe want to rename this AreaDefinitions (plural) to align with the others, RowDefinitions and ColumnDefinitions?
There was a problem hiding this comment.
There is only one area definition per layout definition, whereas row definitions and column definitions are multiple.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4470 CommunityToolkit/Labs-Windows#232
Added attached properties to
Gridelement to enable dynamic layout switching.PR Type
What kind of change does this PR introduce?
Feature
What is the current behavior?
We cannot switch
Gridlayouts dynamically once it's defined.What is the new behavior?
One can define as many layouts (dictionary of string to
GridLayoutDefinition, a newly added data structure to describe a grid layout) as desired in aGridelement and switch among them using the newly addedGridExtensions.ActiveLayout(string, it's the dictionary key of the corresponding layout definition) attached property associated with theGridelement.PR Checklist
Please check if your PR fulfills the following requirements: