Add IAM IBM Cloud utils #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drsm79
requested changes
Sep 3, 2020
arboretum/common/constants.py
Outdated
| @@ -17,6 +17,12 @@ | |||
| # PyPI RSS feed base URL | |||
| PYPI_RSS_BASE_URL = 'https://pypi.org/rss/project' | |||
|
|
|||
| # IBM Cloud token retrieval URL | |||
There was a problem hiding this comment.
I would prefix with IBM or place in ibm_constants
alfinkel
force-pushed
the
9-ibm-iam-utils
branch
from
692ac6f
to
768e1b0
Compare
alfinkel
force-pushed
the
9-ibm-iam-utils
branch
from
768e1b0
to
456190c
Compare
drsm79
approved these changes
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add IAM IBM Cloud utils module with the
get_tokenscommon function.Why
Getting the IAM tokens will be something that can be reused by other fetchers
How
Test
Context
In support of #9