CMP-3589: Add variable for routes rate limit #14023
Conversation
Vincent056
changed the title
…heck Introduce a new variable 'var_routes_excluded_namespaces_regex' to define namespaces that should be excluded from the routes rate limit compliance check.
|
@Vincent056: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
| interactive: false | ||
|
|
||
| options: | ||
| default: "None" |
There was a problem hiding this comment.
Should the default value here be kube and openshift to maintain backwards compatibility?
There was a problem hiding this comment.
that's a good catch, I am hard coding that to be part of the jq filter
| An example allowing additional namespaces follows: | ||
| <pre> | ||
| apiVersion: compliance.openshift.io/v1alpha1 | ||
| kind: TailoredProfile |
There was a problem hiding this comment.
We don't typically put references like this in the rule descriptions. A reference to the documentation might be fine. Also, users consuming these through ACS might have a disjointed experience unless they can access the clusters this applies to.
There was a problem hiding this comment.
That's a good point!
3 participants
Add a variable for excluded namespaces in the routes rate limit check
Introduce a new variable 'var_routes_excluded_namespaces_regex' to define namespaces that should be excluded from the routes rate limit compliance check.