Skip to content

fix: add billcom_auth scheme to sdk #1502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: add billcom_auth scheme to sdk #1502

wants to merge 1 commit into from

Conversation

alt-glitch
Copy link
Collaborator

No description provided.

@entelligence-ai-pr-reviews Entelligence AI PR Reviews
Copy link

⚠️ Trial Period Expired ⚠️

Your trial period has expired. To continue using this feature, please upgrade to a paid plan. You can upgrade your account here - https://entelligence.ai/manage/billing

@vercel Vercel
Copy link

vercel bot commented Mar 27, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
composio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2025 10:41am

shreysingla-bot
shreysingla-bot reviewed Mar 27, 2025
View reviewed changes
python/composio/client/collections.py
@@ -55,6 +55,7 @@
"GOOGLEADS_AUTH",
"NO_AUTH",
"CALCOM_AUTH",
"BILLCOM_AUTH"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding a brief comment explaining what BILLCOM_AUTH is and its use case. This will help future maintainers understand the purpose of this authentication scheme.

shreysingla-bot
shreysingla-bot reviewed Mar 27, 2025
View reviewed changes
python/composio/client/collections.py
@@ -78,6 +80,7 @@
"GOOGLEADS_AUTH",
"NO_AUTH",
"CALCOM_AUTH",
"BILLCOM_AUTH"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider adding BILLCOM_AUTH to the docstring of AuthSchemeType to maintain consistency with other auth schemes in the type definition.

@github-actions GitHub Actions
Copy link
Contributor

This comment was generated by github-actions[bot]!

JS SDK Coverage Report

📊 Coverage report for JS SDK can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/coverage-14104592047/coverage/index.html

📁 Test report folder can be found at the following URL:
https://pub-92e668239ab84bfd80ee07d61e9d2f40.r2.dev/html-report-14104592047/html-report/report.html

@shreysingla-bot
Copy link

Code Review Summary

Changes Overview

  • Added BILLCOM_AUTH authentication scheme to both JavaScript and Python SDKs
  • Changes are consistent across all relevant type definitions and schemas
  • Implementation follows existing patterns for auth scheme integration

Suggestions

  1. Documentation:
    • Add brief comments explaining BILLCOM_AUTH's purpose and use case
    • Consider updating type definition docstrings

Code Quality: ✅ Good

  • Changes are minimal and focused
  • Maintains type safety across both language implementations
  • Follows existing code patterns and structure
  • No apparent bugs or issues

Testing Considerations

  • Consider adding test cases for the new auth scheme
  • Verify integration with Bill.com authentication flow

Overall, the changes look clean and well-structured. Main suggestion is to improve documentation for future maintainability.

@angrybayblade
Copy link
Collaborator

marking stale

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreysingla-bot shreysingla-bot shreysingla-bot left review comments

@sjd9021 sjd9021 Awaiting requested review from sjd9021

@himanshu-dixit himanshu-dixit Awaiting requested review from himanshu-dixit himanshu-dixit is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alt-glitch @shreysingla-bot @angrybayblade