fix: skip defaults when wrapping tools for gemini #1508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![entelligence-ai-pr-reviews[bot]](https://avatars.githubusercontent.com/in/932812?s=60&v=4){kind=small}
|
LGTM 👍 |
Comment on lines
+364
to
+368
| if required: | ||
| default_parameters.append(parameter) | ||
| continue | ||
| none_default_parameters.append(parameter) | ||
| return default_parameters + none_default_parameters |
There was a problem hiding this comment.
The change incorrectly sorts parameters by putting required parameters first instead of non-default parameters first, which breaks Python's parameter ordering rules.
📝 Committable Code Suggestion
‼️ Ensure you review the code suggestion before committing it to the branch. Make sure it replaces the highlighted code, contains no missing lines, and has no issues with indentation.
Suggested change
| if required: | |
| default_parameters.append(parameter) | |
| continue | |
| none_default_parameters.append(parameter) | |
| return default_parameters + none_default_parameters | |
| if default == Parameter.empty: | |
| none_default_parameters.append(parameter) | |
| continue | |
| default_parameters.append(parameter) | |
| return none_default_parameters + default_parameters |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.