fix: humanize field titles in req/res schema #1509
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Devanshusisodiya
requested review from
angrybayblade and
kaavee315
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
LGTM 👍 |
Comment on lines
88
to
90
| class TestClassWithFields(BaseModel): | ||
| baseId: str = Field(..., description="Some random field") | ||
| user_id: str = Field(..., description="Another random field") |
There was a problem hiding this comment.
Add pascal case and nested objects for recursive updates
There was a problem hiding this comment.
Made the test more extensive. Now it covers PascalCase fields and recursive objects.
python/composio/tools/base/abs.py
Outdated
Comment on lines
80
to
83
| if is_camel_case(field_name): | ||
| field_properties["title"] = inflection.titleize( | ||
| inflection.underscore(field_name).replace("_", " ") | ||
| ) |
There was a problem hiding this comment.
Apply normalisation on all cases, no need for the check
There was a problem hiding this comment.
Done, normalizing to snake_case.
|
LGTM 👍 |
|
LGTM 👍 |
|
LGTM 👍 |
angrybayblade
approved these changes
Apr 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When schema is generated for requests with fields like
baseId: str = Field(..., description="The ID of the base")will have titleBaseid. It should be more human readable likeBase Id