fix: graceful fallback when workspace_id doesn't exist in factory #1599
+46
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd try-catch in workspace property to handle ComposioSDKError - Falls back to creating new workspace with provided config - Prevents SweKit crash when invalid workspace_id is set - Add comprehensive unit test for workspace fallback behavior - Fixes ComposioHQ#1228
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Review SummarySkipped posting 1 drafted comments based on your review threshold. Feel free to update them here. Draft Commentspython/composio/tools/toolset.py:1651-1654Scores:
Reason for filtering: The total score is below the threshold of 13 required for inclusion Analysis: The issue is a string formatting error in a debug log message where the second part is not properly formatted with an f-string prefix. While the fix is very clear and specific, the production impact is low since this only affects a debug log message that wouldn't be seen in production. The urgency is also low as debug logs are typically only used during development and wouldn't cause system impairment. |
|
LGTM 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1228