Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing compatibility issues with latest Julia version #19

Closed
wants to merge 2 commits into from

Conversation

vboussange
Copy link
Collaborator

Updated dependencies to make ConScape running on latest Julia version:

  • LightGraphs.jl swapped for Graphs.jl (LightGraphs.jl now deprecated)
  • ProgressLogging.jl swapped for ProgressMeter.jl (ProgresLogging deprecated)

@andreasnoack
Copy link
Member

Where did you see that ProgressLogging has been deprecated? I don't see any such notes at https://github.com/JuliaLogging/ProgressLogging.jl

@vboussange
Copy link
Collaborator Author

No mention of deprecations, but ConScape would fail with latest Julia release, and removing ProgressLogging from the dependencies fixed that. It seems that ProgressLogging requires an old artifact version which conflicts with the ones required by ArchGDAL.

@andreasnoack
Copy link
Member

Thanks for the clarification. ProgressLogging integrates with VS Code so the progress logging is much nicer when using VS Code so I think we should try to keep it. I'll suggest that you restrict this PR to the LightGraph change and then file an issue with the error you see when trying to load ArchGDAL. Then we can debug it in that issue. Hopefully, we can fix whatever needs to be fixed upstream. If the issue can't be resolved then we can switch to ProgrressMeter.

@andreasnoack
Copy link
Member

It looks like something went wrong in the latest commits, see https://github.com/ConScape/ConScape.jl/pull/19/files

@vboussange
Copy link
Collaborator Author

vboussange commented Aug 6, 2024

Hey @andreasnoack, sorry I indeed messed up the commits. Now everything should be fine, with a simple swap from LightGraphs.jl to Graphs.jl. Note that I have also removed the [compat] section in the Project.toml.

I tried to reproduce the previous issue I had with ProgressLogging but I could not - everything seems to work fine as is now.

@andreasnoack
Copy link
Member

Note that I have also removed the [compat] section in the Project.toml.

I don't think that is a good idea. All packages are supposed to have such a section to ensure/help that it doesn't break.

@vboussange
Copy link
Collaborator Author

Fair enough, but in that case you probably want to set up something like CompatHelper, as the version as is probably does not run for latest Julia version.

@andreasnoack
Copy link
Member

in that case you probably want to set up something like CompatHelper

Latest CompatHelper run is six hours old

as the version as is probably does not run for latest Julia version.

Last month's release passed tests on Julia 1.10

🙂

@andreasnoack
Copy link
Member

Superseded by #20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants