-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing compatibility issues with latest Julia version #19
Conversation
Where did you see that ProgressLogging has been deprecated? I don't see any such notes at https://github.com/JuliaLogging/ProgressLogging.jl |
No mention of deprecations, but ConScape would fail with latest Julia release, and removing ProgressLogging from the dependencies fixed that. It seems that ProgressLogging requires an old artifact version which conflicts with the ones required by ArchGDAL. |
Thanks for the clarification. ProgressLogging integrates with VS Code so the progress logging is much nicer when using VS Code so I think we should try to keep it. I'll suggest that you restrict this PR to the LightGraph change and then file an issue with the error you see when trying to load ArchGDAL. Then we can debug it in that issue. Hopefully, we can fix whatever needs to be fixed upstream. If the issue can't be resolved then we can switch to ProgrressMeter. |
It looks like something went wrong in the latest commits, see https://github.com/ConScape/ConScape.jl/pull/19/files |
Hey @andreasnoack, sorry I indeed messed up the commits. Now everything should be fine, with a simple swap from LightGraphs.jl to Graphs.jl. Note that I have also removed the I tried to reproduce the previous issue I had with ProgressLogging but I could not - everything seems to work fine as is now. |
I don't think that is a good idea. All packages are supposed to have such a section to ensure/help that it doesn't break. |
Fair enough, but in that case you probably want to set up something like CompatHelper, as the version as is probably does not run for latest Julia version. |
Latest CompatHelper run is six hours old
Last month's release passed tests on Julia 1.10 🙂 |
Superseded by #20 |
Updated dependencies to make ConScape running on latest Julia version: