Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rasters.jl compatibility #24

Merged
merged 11 commits into from
Dec 13, 2024
Merged

Rasters.jl compatibility #24

merged 11 commits into from
Dec 13, 2024

Conversation

rafaqz
Copy link
Collaborator

@rafaqz rafaqz commented Dec 2, 2024

Allow passing a Rasters.jl raster for source and target matrices (or any other DimensionalData.jl compatable array, e.g. YAXArrays will work too).

When these are passed output arrays from various functions of Grid and GridRSP that currently return a Matrix will return a Raster with correct spatial metadata.

Plotting is also modified to use Rasters.jl plot recipes where possible, so that plot ticks have spatial values.

Plotting with Plots.jl, Makie.jl and GeoMakie.jl will also "just work" on output Rasters, so eventually the Plots.jl dependency could be dropped.

@rafaqz rafaqz changed the base branch from main to dev December 12, 2024 08:52
@rafaqz rafaqz closed this Dec 12, 2024
@rafaqz rafaqz reopened this Dec 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Please upload report for BASE (dev@c18ca9b). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/gridrsp.jl 90.90% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##             dev      #24   +/-   ##
======================================
  Coverage       ?   93.18%           
======================================
  Files          ?        6           
  Lines          ?      675           
  Branches       ?        0           
======================================
  Hits           ?      629           
  Misses         ?       46           
  Partials       ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rafaqz rafaqz marked this pull request as ready for review December 12, 2024 10:26
@rafaqz rafaqz merged commit 4b878ad into ConScape:dev Dec 13, 2024
4 checks passed
@rafaqz rafaqz deleted the rasters branch December 13, 2024 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants