Skip to content

feat: add pipelines ls cmd (+client API) #2063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 33 commits into from
Jan 16, 2025
Merged

feat: add pipelines ls cmd (+client API) #2063

merged 33 commits into from
Jan 16, 2025

Conversation

raulb
Copy link
Member

@raulb raulb commented Jan 10, 2025 •
edited
Loading

Description

  • Fixes CLI: conduit pipelines ls #2019
  • Adds a gRPC client that will be used in the rest of the commands that require Conduit to be running.
  • Adds a custom decorator ExecuteWithClient that parses the global flags, needed to correctly the client address.

Quick checks

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

lovromazgon
lovromazgon reviewed Jan 10, 2025
View reviewed changes
hariso
hariso reviewed Jan 10, 2025
View reviewed changes
hariso
hariso reviewed Jan 10, 2025
View reviewed changes
raulb added 20 commits January 13, 2025 13:11
@raulb
Merge branch 'main' into cli-api
35c546a
@raulb
include alias for pipelines cmd
57731af
@raulb
hide columns for now
09737a6 
We'll augment these on pipeline describe and see how it feels
@raulb
Merge branch 'cli-api' of github.com:ConduitIO/conduit into cli-api
0399a26
@raulb
fix api flags (+test)
7cca50d
@raulb
Merge branch 'fix-api-flags' into cli-api
f2e0a24
@raulb
Merge branch 'main' into cli-api
883dfb1
@raulb
use pipeline service directly
e7e806b
@raulb
Merge branch 'cli-api' of github.com:ConduitIO/conduit into cli-api
ba0e396
@raulb
update flag names
1172ff0
@raulb
Merge branch 'fix-api-flags' into cli-api
0663c87
@raulb
remove testing boolean
935b419
@raulb
add ExecuteWithClient decorator
dce673d
@raulb
fix double conn err msg
879808f
@raulb
better approach
99b61bb
@raulb
include comment
efa60df
@raulb
read from the same addresss
b32c7c0
@raulb
fix ci
d137403
@raulb
fix ci II
5e96490
@raulb
fix tests
94120ba
@raulb raulb mentioned this pull request Jan 15, 2025
Merged
@raulb raulb marked this pull request as ready for review January 15, 2025 16:18
@raulb raulb requested a review from a team as a code owner January 15, 2025 16:18
@raulb raulb requested review from hariso and lovromazgon January 15, 2025 16:24
hariso
hariso reviewed Jan 15, 2025
View reviewed changes
@raulb raulb requested a review from hariso January 15, 2025 19:25
maha-mstfa
maha-mstfa approved these changes Jan 16, 2025
View reviewed changes
Copy link
Contributor

@maha-mstfa maha-mstfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! the PR code is well written and structured :D

hariso
hariso approved these changes Jan 16, 2025
View reviewed changes
@raulb raulb enabled auto-merge (squash) January 16, 2025 11:10
@raulb raulb merged commit 1745afd into main Jan 16, 2025
4 checks passed
@raulb raulb deleted the cli-api branch January 16, 2025 11:16
@chenrui333 chenrui333 mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maha-mstfa maha-mstfa maha-mstfa approved these changes

@hariso hariso hariso approved these changes

@lovromazgon lovromazgon Awaiting requested review from lovromazgon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI: conduit pipelines ls
4 participants
@raulb @hariso @lovromazgon @maha-mstfa