Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(comms)!: new communications module that merges SMS, Push and Email into a single service #1160

Open
wants to merge 14 commits into
base: v-next
Choose a base branch
from

Conversation

kkopanidis
Copy link
Contributor

@kkopanidis kkopanidis commented Sep 18, 2024

This PR implements #122 merging the SMS, Push Notifications and Email modules into a single Comms module. The aim of this merge is to:

  • Reduce the required memory of the modules
  • Simplify operations
  • Allow for increased features like communication preferences and easier user notifications without channel picks

Tasks:

  • Merge modules
  • Migrations for configuration
  • Migrations for schemas
  • Migration for admin routes
  • Migrate current usage of sub-services in other modules

This is a breaking change, to be merged in v-next branch for version 0.17.x

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

Other information:

…ants actions (#1135)

* refactor(chat): sendInvitation props as object

* fix(chat): missing populate query param from router

* fix(chat): missing search message regex matching

* chore(chat): cleanups

* fix(chat): router invitation token count

* refactor(chat): admin route createRoom participants logs, set creator

* refactor(chat): participants actions

* fix(chat): router query params id types

* feat(chat): router remove member from room route

* fix(chat): admin route getRooms missing params

* fix(chat): admin route deleteRooms missing audit-mode config check

* feat(chat): admin route removeUsers/addUsers/roomInvitations/roomById

* feat(chat): participants join log on invitation accept
modules/comms/src/Comms.ts Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Merge Push, Email & SMS modules
3 participants