Skip to content

Conversation

@boqiu
Copy link
Contributor

@boqiu boqiu commented Dec 1, 2025

This change is Reviewable

@boqiu boqiu requested a review from wanliqun December 1, 2025 09:58
@codecov
Copy link

codecov bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 53.33333% with 105 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.41%. Comparing base (5b84241) to head (6241d95).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
store/leveldb/store_shard.go 48.74% 86 Missing and 16 partials ⚠️
store/leveldb/store_rw.go 88.23% 1 Missing and 1 partial ⚠️
store/leveldb/store.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #73      +/-   ##
==========================================
- Coverage   77.64%   74.41%   -3.24%     
==========================================
  Files          20       21       +1     
  Lines        1360     1278      -82     
==========================================
- Hits         1056      951     -105     
- Misses        260      268       +8     
- Partials       44       59      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@wanliqun wanliqun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@wanliqun reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @boqiu)

@boqiu boqiu merged commit 5be6bd2 into main Dec 1, 2025
2 of 4 checks passed
@boqiu boqiu deleted the store-leveldb-sharding branch December 1, 2025 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants