Get original exception in case of re-raise #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@epergo Any chance of a test? :D |
* ActionView captures exceptions when compiling templates and launches its custom error, ActionView::Template::Error, this re-raising makes the exception to loose its context and therefore pry-rescue don't know how to `cd-cause` to the root of the problem.
|
Here you have! Without the fix this tests fails because when you |
|
Thanks! |
|
P.S. I've added you as a collaborator on this repo, feel free to go wild :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
I've recently discovered this gem and I love it! But unfortunately when I was testing it out in my Rails project I got to the point where I faced an error in one of my views and after checking the project's issues I found #89 :(
After learning about Rails
Template::Errorclass I have found that the original exception is stored in its attributecauseso in order tocdto that exception I have modified yourcd-causemethod to check if there is acauseexception and in that casecdthere.Rails source about what I am talking about:
https://github.com/rails/rails/blob/master/actionview/lib/action_view/template/error.rb#L68
Tests are passing and I have tested against @yar sample project too, https://github.com/yar/p-r-test
Now you can
cd-causecorrectly to the root of the problem and see what is happening(@yar post #89 (comment))