This repository was archived by the owner on Feb 26, 2024. It is now read-only.
Add Testing ether transactions example#55
Open
vincentlg wants to merge 2 commits intoConsenSys-archive:masterfrom
Open
Add Testing ether transactions example#55vincentlg wants to merge 2 commits intoConsenSys-archive:masterfrom
vincentlg wants to merge 2 commits intoConsenSys-archive:masterfrom
Conversation
I propose this because I had trouble finding the syntax to do that (There may be a simpler way to indicate this...)
Contributor
|
Do we really want this? It seems like it might be more appropriate in the Solidity docs as it is mostly Solidity syntax. Is that right? |
fainashalts
reviewed
Jun 23, 2021
fainashalts
reviewed
Jun 23, 2021
| ``` | ||
| Here is the code to test the `payable` function `contribute` with a `string _message` in parameter | ||
|
|
||
| ```javascript |
Contributor
There was a problem hiding this comment.
Suggested change
| ```javascript | |
| ```solidity |
haltman-at
reviewed
Jun 23, 2021
| function testContribute() public { | ||
| // Expected contribute increase amountRaised | ||
| uint256 expected = 5 ether; | ||
| campaign.contribute.value(5 ether) ("my test message"); |
Contributor
There was a problem hiding this comment.
Note that the .value syntax doesn't exist anymore in current versions of Solidity. We probably want this to be up to date, so the syntax would be campagain.contribute{value: 5 ether}("my test message").
Co-authored-by: Faina Shalts <[email protected]>
cds-amal
changed the title
Contributor
|
Since this is out of date, should we close this PR? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I propose this because I had trouble finding the syntax to do that (There may be a simpler way to indicate this...)