-
Notifications
You must be signed in to change notification settings - Fork 465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added New tutorials for Linea #927
base: main
Are you sure you want to change the base?
Conversation
@meowyx is attempting to deploy a commit to the Consensys Team on Vercel. A member of the Team first needs to authorize it. |
will be updating and making more changes for the next few days! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of comments but don't be dismayed by the quantity — a lot of are just implementing sentence case! Thanks for putting this together. Let me know if I can expand on any of the comments.
Also since this is just the marketplace dapp, I assume you intend to add the other two guides to this PR at some point?
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
Co-authored-by: Joel Willmore <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the second tutorial, very thorough!
A few overarching points:
- As mentioned last time, all subheadings and headings should be sentence case
- There are a few places where things are capitalised unnecessarily. The only places where we should be capitalising are proper nouns (e.g. product/feature names) or where gramatically necessary.
I think we can simplify the folder structure, i.e.Implemented this is in my commitmarketplace-dapp.mdx
andvoting-dapp.mdx
can just live withindocs/learn
rather than as orphan files in their own directories- The sidebar is manual, in
sidebars.js
, and needs to be updated. I'll push up a commit with this and a few other adjustments we need to make sure the link appears in the navbar too.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding 2 new tutorials: