Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added New tutorials for Linea #927

Open
wants to merge 30 commits into
base: main
Choose a base branch
from
Open

Conversation

meowyx
Copy link

@meowyx meowyx commented Jan 8, 2025

Adding 2 new tutorials:

  • marketplace dapp
  • voting dapp

Copy link

vercel bot commented Jan 8, 2025

@meowyx is attempting to deploy a commit to the Consensys Team on Vercel.

A member of the Team first needs to authorize it.

@meowyx
Copy link
Author

meowyx commented Jan 8, 2025

will be updating and making more changes for the next few days!
feel free to leave any review.

Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of comments but don't be dismayed by the quantity — a lot of are just implementing sentence case! Thanks for putting this together. Let me know if I can expand on any of the comments.

Also since this is just the marketplace dapp, I assume you intend to add the other two guides to this PR at some point?

docs/learn/marketplace-dapp/index.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
meowyx and others added 19 commits January 13, 2025 18:21
@meowyx meowyx requested a review from jlwllmr January 14, 2025 14:14
Copy link
Collaborator

@jlwllmr jlwllmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the second tutorial, very thorough!

A few overarching points:

  • As mentioned last time, all subheadings and headings should be sentence case
  • There are a few places where things are capitalised unnecessarily. The only places where we should be capitalising are proper nouns (e.g. product/feature names) or where gramatically necessary.
  • I think we can simplify the folder structure, i.e. marketplace-dapp.mdx and voting-dapp.mdx can just live within docs/learn rather than as orphan files in their own directories Implemented this is in my commit
  • The sidebar is manual, in sidebars.js, and needs to be updated. I'll push up a commit with this and a few other adjustments we need to make sure the link appears in the navbar too.

docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/marketplace-dapp/marketplace-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
docs/learn/voting-dapp/voting-dapp.mdx Outdated Show resolved Hide resolved
@jlwllmr jlwllmr requested a review from Gwen-M January 31, 2025 11:22
Copy link

vercel bot commented Jan 31, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
doc-zk-evm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 8:55am

Copy link
Collaborator

@Gwen-M Gwen-M left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @jlwllmr and @meowyx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants