fix(math/bitslice): fix partition upper part range check width #1165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1153.
Also handle separately case when
nbDigits >= Fr width
as we need to check that we do not overflow and use unique decomposition. There isn't a better way beyond doing bit-by-by comparison against the modulus, so this case is deferred tomath/bits
package.Added some package documentation.
Shouldn't affect current usage of the implementation as we call everywhere with
nbDigits
small.Type of change
How has this been tested?
Checklist:
golangci-lint
does not output errors locally