Skip to content

fix: enable fuzzing for multi-output-hint test by improving dvHint validation #1517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 23, 2025

Conversation

ruslan0012
Copy link
Contributor

@ruslan0012 ruslan0012 commented Jun 19, 2025

Description

Fixed issue with multi-output-hint test that required disabling fuzzing. Added proper input validation to the dvHint function to handle edge cases during fuzzing and removed the NoFuzzing() option from the integration test.

Fixes # (issue related to multi-output-hint fuzzing)

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

  • Ran integration tests with fuzzing enabled for multi-output-hint test
  • Verified dvHint function properly handles invalid inputs

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@ivokub
Copy link
Collaborator

ivokub commented Jun 20, 2025

Thanks for the PR. I don't even recall why we disabled multi-output hint test, I think at some point it broke some functionality. I'll have a look at the PR and history and see if we can merge it.

Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - short tests seem to pass. I'll merge and see if the long tests also pass.

@ivokub ivokub merged commit c881f45 into Consensys:master Jun 23, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants