Skip to content

Conversation

@alainncls
Copy link
Collaborator

@alainncls alainncls commented Oct 16, 2025

Note

Enables mTLS between PoH Signer API and Web3Signer, adds a global HTTP exception filter, improves signing logs, and updates Web3Signer config/paths to key-files with TLS assets.

  • Backend (poh-signer-api):
    • Security/mTLS: Always use HTTPS agent for Web3Signer; build agent from client pfx and trusted CA from truststore with rejectUnauthorized/requestCert; stricter config validation (requires keystore/truststore fields); richer debug/timing logs and detailed error logs; remove dev-mode skips.
    • Error Handling: Add global HttpExceptionFilter and register in main.ts; simplify poh.controller to validate address and delegate to services (no local try/catch); standardized JSON error responses.
    • Env: Populate WEB3SIGNER_* keystore/truststore vars in .env.example.
  • Web3Signer service:
    • TLS: Pin image consensys/web3signer:25.2; enable TLS flags (--tls-keystore-file, --tls-keystore-password-file, --tls-known-clients-file); mount tls-files/; update config key-store-path to /key-files/.
    • Assets: Add tls-files/known-clients.txt and tls-files/web3signer-keystore-password.txt.
    • Paths: Rename keyFileskey-files in config, volumes, and .gitignore.
  • Docs:
    • Update READMEs to use key-files/ paths and fix minor formatting.

Written by Cursor Bugbot for commit 817b29a. This will update automatically on new commits. Configure here.

@alainncls alainncls self-assigned this Oct 16, 2025
@alainncls alainncls requested a review from a team as a code owner October 16, 2025 13:54
@alainncls alainncls force-pushed the chore/add-logs-when-calling-web3signer branch 2 times, most recently from 0fd1cb3 to 4f86537 Compare October 16, 2025 16:48
@alainncls alainncls force-pushed the chore/add-logs-when-calling-web3signer branch from 4f86537 to 817b29a Compare October 17, 2025 09:01
@alainncls alainncls merged commit 973cf99 into main Oct 17, 2025
7 checks passed
@alainncls alainncls deleted the chore/add-logs-when-calling-web3signer branch October 17, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants