Skip to content

Conversation

@alainncls
Copy link
Collaborator

@alainncls alainncls commented Oct 23, 2025

Note

Removes rejectUnauthorized from the HTTPS Agent options used to call Web3Signer.

  • Backend
    • HTTPS Agent Configuration: Remove rejectUnauthorized from createWeb3SignerHttpsAgent in packages/poh-signer-api/src/modules/signer/signer.service.ts.

Written by Cursor Bugbot for commit d46e8a1. This will update automatically on new commits. Configure here.

@alainncls alainncls self-assigned this Oct 23, 2025
@alainncls alainncls requested a review from a team as a code owner October 23, 2025 15:44
@alainncls alainncls merged commit ff7970c into main Oct 23, 2025
4 checks passed
@alainncls alainncls deleted the fix/ssl-connection branch October 23, 2025 15:44
Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: SSL Validation Bypass in HTTPS Agent

Removing rejectUnauthorized: true from the HTTPS Agent configuration disables SSL certificate validation. In Node.js, when rejectUnauthorized is not explicitly set, it defaults to false, allowing connections to servers with invalid, expired, or untrusted certificates. This creates a serious vulnerability to man-in-the-middle attacks when connecting to Web3Signer.

packages/poh-signer-api/src/modules/signer/signer.service.ts#L174-L180

return new Agent({
pfx: clientPfx,
passphrase: keystorePassphrase,
ca: caCertPem,
requestCert: true,
});

Fix in Cursor Fix in Web


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants