Skip to content

OZ native yield audit combined fixes #1750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: cyfrin-native-yield-audit-combined-fixes
Choose a base branch
from
Open

OZ native yield audit combined fixes #1750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b9871bb
YieldManager - change location of YieldProviderStakingPaused and Yiel…
kyzooghost Nov 19, 2025
1e33879
switch expected order of event emission in YieldManager.controls.ts f…
kyzooghost Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/contracts/yield/YieldManager.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -786,7 +786,6 @@ contract YieldManager is
revert StakingAlreadyPaused();
}
_pauseStaking(_yieldProvider);
emit YieldProviderStakingPaused(_yieldProvider);
}

/**
Expand All @@ -796,6 +795,7 @@ contract YieldManager is
function _pauseStaking(address _yieldProvider) internal {
_delegatecallYieldProvider(_yieldProvider, abi.encodeCall(IYieldProvider.pauseStaking, (_yieldProvider)));
_getYieldProviderStorage(_yieldProvider).isStakingPaused = true;
emit YieldProviderStakingPaused(_yieldProvider);
}

/**
Expand Down Expand Up @@ -837,7 +837,6 @@ contract YieldManager is
revert UnpauseStakingForbiddenDuringPendingOssification();
}
_unpauseStaking(_yieldProvider);
emit YieldProviderStakingUnpaused(_yieldProvider);
}

/**
Expand All @@ -847,6 +846,7 @@ contract YieldManager is
function _unpauseStaking(address _yieldProvider) internal {
_delegatecallYieldProvider(_yieldProvider, abi.encodeCall(IYieldProvider.unpauseStaking, (_yieldProvider)));
_getYieldProviderStorage(_yieldProvider).isStakingPaused = false;
emit YieldProviderStakingUnpaused(_yieldProvider);
}

/**
Expand Down
2 changes: 2 additions & 0 deletions contracts/test/yield/unit/YieldManager.controls.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -388,6 +388,8 @@ describe("YieldManager contract - control operations", () => {
const { mockYieldProviderAddress } = await addMockYieldProvider(yieldManager);

await expect(yieldManager.connect(securityCouncil).initiateOssification(mockYieldProviderAddress))
.to.emit(yieldManager, "YieldProviderStakingPaused")
.withArgs(mockYieldProviderAddress)
.to.emit(yieldManager, "YieldProviderOssificationInitiated")
.withArgs(mockYieldProviderAddress);

Expand Down
Loading