-
Notifications
You must be signed in to change notification settings - Fork 130
updates Readme to link to active repos & minor style fixes #1869
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
|
README.md
Outdated
| - [linea-besu](https://github.com/Consensys/linea-besu): Fork of Besu to implement the Linea-Besu client | ||
| - [linea-sequencer](https://github.com/Consensys/linea-sequencer): A set of Linea-Besu plugins for the sequencer and RPC nodes | ||
| > Also maintains a set of Linea-Besu plugins for the sequencer and RPC nodes. | ||
| - [linea-besu](https://github.com/hyperledger/besu/): Besu execution client |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we're using Besu, I'd just say "Besu" instead of "linea-besu" here:
- [Besu](https://github.com/hyperledger/besu/): Besu execution client
Maybe also list and link the mentioned plugins.
Finally, I'd also consider adding:
- Linea Besu Upstream: Upstream Besu build for Linea
- Maru: Consensus client used by Linea L2.
@julien-marchand what are your thoughts on this? anything missing here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eloi010 Julien had similar comment on the constraints update --> my proposal is line 27: add besu to the "what is" section. Julien approved this for constraints, does it work here too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@julien-marchand is the best one to confirm here. I'd still consider mentioning other repos like Linea Besu Upstream. For Maru in line 27, I'd explicitly say that it is the consensus client in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@eloi010 apologies, you did clearly did mention that repo: added with suggested summary line
This PR implements issue(s) #1868
Checklist
Note
Updates README with client compatibility details, refreshed repository links, and minor wording/style tweaks.
Besu/GethwithMaru.linea-monorepo) and note it maintains Linea-Besu plugins for sequencer/RPC nodes.linea-besuwithlinea-besu-upstream; removelinea-sequencer.Written by Cursor Bugbot for commit 312c665. This will update automatically on new commits. Configure here.