[5.9] Pause staking in fundYieldProvider #1945
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eficit exists - Add check in fundYieldProvider to pause staking if target reserve deficit > 0 - Update test helpers to use target reserve amount instead of minimum - Add test assertions to verify staking is paused after funding with deficit - Update test setup to properly configure withdrawal reserve state
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| const minimumReserveAmount = await testYieldManager.minimumWithdrawalReserveAmount(); | ||
| const targetReserveAmount = await testYieldManager.targetWithdrawalReserveAmount(); | ||
| const l1MessageServiceAddress = await testYieldManager.getL1MessageService(); | ||
| await ethers.provider.send("hardhat_setBalance", [l1MessageServiceAddress, ethers.toBeHex(minimumReserveAmount)]); |
There was a problem hiding this comment.
Bug: Test helpers use absolute target instead of effective target
The helpers fundYieldProviderForWithdrawal and fundLidoStVaultYieldProvider use targetWithdrawalReserveAmount() (absolute value), but getTargetReserveDeficit() in production code checks against _getEffectiveTargetWithdrawalReserve() (effective value that considers percentage-based calculation). The existing helper setWithdrawalReserveToTarget correctly uses getEffectiveTargetWithdrawalReserve(). For large withdrawAmount values where totalSystemBalance exceeds 5000 ETH, the effective target becomes percentage-based and exceeds the absolute target, causing an unexpected deficit and triggering the pause even though the helper's intent was to avoid one.
Additional Locations (1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist
Note
Pauses staking during
fundYieldProviderifgetTargetReserveDeficit() > 0, and updates test helpers/tests to use target reserve and verify pause behavior.contracts/contracts/yield/YieldManager.sol):fundYieldProviderwhengetTargetReserveDeficit() > 0via_pauseStakingIfNotAlready.minimumWithdrawalReserveAmounttotargetWithdrawalReserveAmountinhelpers/setup.ts.setWithdrawalReserveToMinimum(and reserve-balance helpers) to configure reserve state using effective thresholds.YieldManager.funds.ts):isStakingPausedistrueafter funding with target deficit.safeAddToWithdrawalReserve).Written by Cursor Bugbot for commit f55662a. This will update automatically on new commits. Configure here.