Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stack output for SLOAD #45

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Fix stack output for SLOAD #45

merged 10 commits into from
Jan 16, 2025

Conversation

OlivierBBB
Copy link
Collaborator

SLOAD must only write to the stack if unexceptional. This simplifies the tracing (in case of an SLOAD that raises the OOGX flag and attempts to load a nonzero value from storage.)

Copy link

cla-assistant bot commented Jan 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

1 similar comment
Copy link

cla-assistant bot commented Jan 10, 2025

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@OlivierBBB OlivierBBB enabled auto-merge (squash) January 10, 2025 13:40
@OlivierBBB OlivierBBB disabled auto-merge January 16, 2025 19:20
@OlivierBBB OlivierBBB merged commit 885b71b into main Jan 16, 2025
1 check was pending
@OlivierBBB OlivierBBB deleted the SLOAD-fix-stack-output branch January 16, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant