Skip to content

PUSHVALUE fix for exceptional PUSHes #1658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 14, 2024
Merged

PUSHVALUE fix for exceptional PUSHes #1658

merged 3 commits into from
Dec 14, 2024

Conversation

OlivierBBB
Copy link
Collaborator

Ugly hack. Can be optimized to

  • use getPushValue if and only if there is an exception
  • use the old approach if there is no exception

@OlivierBBB OlivierBBB self-assigned this Dec 14, 2024
@OlivierBBB OlivierBBB merged commit 5e9e21a into arith-dev Dec 14, 2024
7 checks passed
@OlivierBBB OlivierBBB deleted the PUSHVALUE-fix-for-exceptional-pushes branch December 14, 2024 11:40
DavePearce
DavePearce reviewed Dec 15, 2024
View reviewed changes
Copy link
Collaborator

@DavePearce DavePearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavePearce DavePearce DavePearce left review comments

@lorenzogentile404 lorenzogentile404 Awaiting requested review from lorenzogentile404

Assignees

@OlivierBBB OlivierBBB

Labels
debugging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OlivierBBB @DavePearce