Various SELFDESTRUCT related fixes
#1661
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OlivierBBB
commented
Dec 15, 2024
| if (isDeployment) { | ||
| selfdestructorNew = selfdestructorNew.deploymentStatus(false); | ||
| selfdestructorNew.code(Bytecode.EMPTY); | ||
| } |
There was a problem hiding this comment.
Unexceptional SELFDESTRUCT's in deployment contexts trigger an empty deployment. Thus we reset the byte code (from init code to Bytes.EMPTY.)
There is a subtle point with selt-targeting SELFDESTRUCT's: for the two "doing" account-rows the HUB_STAMP remains the same. We therefore cannot use the following definition markedForSelfDestruct = hubStamp > selfDestructTime since the second time we inspect the account, this time as the "recipient", the flag ought to be true. Instead we must differentiate according to the DOM_STAMP which reads - row 1: hubStamp * MULTIPLIER___DOM_SUB_STAMPS + 0 - row 2: hubStamp * MULTIPLIER___DOM_SUB_STAMPS + 1 This is what we fix here
OlivierBBB
commented
Dec 15, 2024
| @@ -173,7 +174,8 @@ public void resolvePostTransaction( | |||
| new EphemeralAccount(oldState.address(), oldState.deploymentNumber()); | |||
| if (effectiveSelfDestructMap.containsKey(ephemeralAccount)) { | |||
| final int selfDestructTime = effectiveSelfDestructMap.get(ephemeralAccount); | |||
| markedForSelfDestruct = hubStamp > selfDestructTime; | |||
| markedForSelfDestruct = | |||
| domSubStampsSubFragment.domStamp() > MULTIPLIER___DOM_SUB_STAMPS * selfDestructTime; | |||
There was a problem hiding this comment.
This is a subtle point with respect to self-targeting SELFDESTRUCT's. For the two "doing" account-rows the HUB_STAMP remains the same. We therefore cannot use the following definition
markedForSelfDestruct = hubStamp > selfDestructTime; // won't work on the 2nd row
markedForSelfDestructNew = hubStamp >= selfDestructTime;since the second time we inspect the account, this time as the "recipient", the flag ought to be true yet the parameters of this equation haven't changed. Instead we now differentiate according to the DOM_STAMP.
markedForSelfDestruct = domSubStampsSubFragment.domStamp() > MULTIPLIER___DOM_SUB_STAMPS * selfDestructTime;
markedForSelfDestructNew = hubStamp >= selfDestructTime;This achieves the following result, for
// self-targeting SELFDESTRUCT's
- row 1: hubStamp * MULTIPLIER___DOM_SUB_STAMPS + 0 => markedForSelfDestruct ≡ false
- row 2: hubStamp * MULTIPLIER___DOM_SUB_STAMPS + 1 => markedForSelfDestruct ≡ true
This is what we fix here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.