Skip to content

EIP-3651-warm-coinbase #1961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
letypequividelespoubelles merged 41 commits into from
Apr 14, 2025
Merged

EIP-3651-warm-coinbase #1961

letypequividelespoubelles merged 41 commits into from
Apr 14, 2025

Conversation

@letypequividelespoubelles
Copy link
Collaborator

@letypequividelespoubelles letypequividelespoubelles commented Apr 2, 2025

No description provided.

@letypequividelespoubelles
EIP-3651-warm-coinbase
6291128 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles letypequividelespoubelles linked an issue Apr 2, 2025 that may be closed by this pull request
EIP 3651: warm coinbase #1956
Closed
@letypequividelespoubelles
rebase
64c2de3 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
wip
87bd587 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles letypequividelespoubelles changed the base branch from arith-dev to shanghai-hard-fork April 4, 2025 10:11
@letypequividelespoubelles
fix: ras
44ca96d 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
shanghai hard fork
a320ba9 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
fix constraints
fec753c 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
ras
53123ca 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles letypequividelespoubelles marked this pull request as ready for review April 4, 2025 11:15
OlivierBBB
OlivierBBB approved these changes Apr 7, 2025
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some comments.

letypequividelespoubelles and others added 16 commits April 9, 2025 09:44
@letypequividelespoubelles
ras
79ded4f 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
Merge branch 'shanghai-hard-fork' into eip-3651-warm-coinbase
a1276fc
@letypequividelespoubelles
Init section is fork dependant
5738fe1 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
coinbase warmth at tx end
942dc35 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
rollback txFinalization
f36fb72 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
fix dom/sub offset are fork dependant
3bcf05f 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
fix sender coinbase collision, warmth is fork dependant
be3efbe 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
make the constructor uses final
9e6ae9e 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
Merge branch 'shanghai-hard-fork' into eip-3651-warm-coinbase
03c0170
@letypequividelespoubelles
spotless
524dd21 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
ras
422d8dd 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
ras
875f9aa 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
Merge branch 'arith-dev' into shanghai-hard-fork
4388d03
@letypequividelespoubelles
Merge branch 'shanghai-hard-fork' into eip-3651-warm-coinbase
b28fff1
@letypequividelespoubelles
set finalization section only onbce
9b0e56a 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles
fix account warmth for initialization section
7d6ae3d 
Signed-off-by: F Bojarski <[email protected]>
@letypequividelespoubelles letypequividelespoubelles added the hardfork shanghai EIP's for the Shanghai hardfork label Apr 11, 2025
OlivierBBB
OlivierBBB approved these changes Apr 14, 2025
View reviewed changes
Copy link
Collaborator

@OlivierBBB OlivierBBB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I think there may be an issue with the domStampOffset but otherwise looks good to me.

Base automatically changed from shanghai-hard-fork to arith-dev April 14, 2025 13:19
@letypequividelespoubelles letypequividelespoubelles enabled auto-merge (squash) April 14, 2025 20:14
@letypequividelespoubelles letypequividelespoubelles merged commit ec1c2d4 into arith-dev Apr 14, 2025
7 checks passed
@letypequividelespoubelles letypequividelespoubelles deleted the eip-3651-warm-coinbase branch April 14, 2025 20:32
jonesho pushed a commit that referenced this pull request Nov 24, 2025
@letypequividelespoubelles
EIP-3651-warm-coinbase (#1961)
deafa91 
Signed-off-by: F Bojarski <[email protected]>
jonesho pushed a commit that referenced this pull request Dec 4, 2025
@letypequividelespoubelles
EIP-3651-warm-coinbase (#1961)
da02f50 
Signed-off-by: F Bojarski <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OlivierBBB OlivierBBB OlivierBBB approved these changes

@lorenzogentile404 lorenzogentile404 Awaiting requested review from lorenzogentile404

Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels

hardfork shanghai EIP's for the Shanghai hardfork

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

EIP 3651: warm coinbase

3 participants

@letypequividelespoubelles @OlivierBBB