feat: make jar release condition to unit and replay passing by default' #2469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
9107e69 to
eb7d3d9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+15
to
+53
| runs-on: gha-runner-scale-set-ubuntu-22.04-amd64-xxl | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@08c6903cd8c0fde910a37f88322edcfb5dd907a8 # v5.0.0 | ||
| with: | ||
| submodules: false | ||
|
|
||
| - name: Setup Environment | ||
| uses: ./.github/actions/setup-environment | ||
| with: | ||
| enable-ssh: ${{ inputs.tests-with-ssh }} | ||
|
|
||
| - name: Run replay tests | ||
| run: GOMEMLIMIT=26GiB ./gradlew :arithmetization:fastReplayTests | ||
| env: | ||
| JAVA_OPTS: -Dorg.gradle.daemon=false | ||
| JUNIT_TESTS_PARALLELISM: 4 | ||
| GOCORSET_FLAGS: -b1024 -v --ansi-escapes=false --report --air | ||
|
|
||
| - name: Upload test report | ||
| if: ${{ always() }} | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| with: | ||
| name: replay-tests-report | ||
| path: arithmetization/build/reports/tests/**/* | ||
|
|
||
| - name: Upload jacoco fast replay tests coverage report | ||
| if: always() | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| with: | ||
| name: jacoco-fast-replay-tests-coverage-report | ||
| path: arithmetization/build/reports/jacoco/jacocoFastReplayTestsReport/**/* | ||
|
|
||
| - name: Upload jacoco fast replay tests exec file | ||
| if: always() | ||
| uses: actions/upload-artifact@ea165f8d65b6e75b540449e92b4886f43607fa02 # v4.6.2 | ||
| with: | ||
| name: jacoco-fast-replay-tests-exec-file | ||
| path: arithmetization/build/jacoco/fastReplayTests.exec |
Check warning
Code scanning / CodeQL
Workflow does not contain permissions Medium
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix
AI about 11 hours ago
To address the problem, we should explicitly add a permissions block to the workflow. Since all jobs in the workflow only check out the repository, run tests, and upload artifacts, the minimum required is nearly always contents: read. This will prevent the workflow from inheriting more permissive defaults set at the repository or organization level. The permissions block should be added at the top level of the workflow file (just after the name and before on) to apply to all jobs by default. No changes to the workflow steps or additional configuration are required.
Suggested changeset
1
.github/workflows/reusable-fast-replay-tests.yml
| @@ -1,4 +1,6 @@ | ||
| name: "Reusable fast replay tests workflow" | ||
| permissions: | ||
| contents: read | ||
|
|
||
| on: | ||
| workflow_call: |
Copilot is powered by AI and may make mistakes. Always verify output.
Unable to commit as this autofix suggestion is now outdated
amkCha
force-pushed
the
feat/unit-replays-condition-to-jar-release
branch
from
eb7d3d9 to
44987a2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
Refactors fast replay tests into a reusable workflow and makes release publishing wait for unit and fast replay tests by default, with an option to publish immediately.
/.github/workflows/reusable-fast-replay-tests.ymlencapsulating checkout, environment setup, running:arithmetization:fastReplayTests, and uploading reports.gradle-tests.ymlto use the reusable fast replay workflow; propagatetests-with-sshinput.manual-release.yml, switch fast replay tests to the reusable workflow and keep onlyunit-tests-prague.wait-for-tests-bef-publishinput (defaulttrue).publish-conditional-to-units-and-replay-testsjob gated on passing unit (Prague) and fast replay tests; publish via./gradlew publishwith Cloudsmith creds.publish-as-soon-as-readyjob to publish immediately when the input isfalse.Written by Cursor Bugbot for commit ba3d69d. This will update automatically on new commits. Configure here.