chore: add unit test for get-starknet event #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…urrent-account-from-state
…change-get-starknet
khanti42
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
stanleyyconsensys
requested changes
Jan 21, 2025
Base automatically changed from
feat/account-event-change-get-starknet
to
feat/enable-multiple-accounts
January 22, 2025 02:28
stanleyyconsensys
merged commit c233cc8
into
feat/enable-multiple-accounts
3 checks passed
stanleyyconsensys
deleted the
feat/account-event-change-get-starknet-unittest
branch
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add the unit test for get-starknet event
Changes:
MockMetaMaskSnapWalletto extendsMetaMaskSnapWalletand override some properties to allow spyaccountChanged / networkChangedeventpollingTimeoutMsandpollingDelayMsinMetaMaskSnapWalletto protected, which to enableMockMetaMaskSnapWalletto mock it