feat: enable multi discovery strategy #492
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khanti42
requested review from
Julink-eth and
stanleyyconsensys
and removed request for
a team
| const account = await invokeSnap<Account>({ | ||
| method: 'starkNet_addAccount', | ||
| params: { | ||
| chainId, | ||
| accountDiscoveryType: urlParams.get('accountDiscovery'), |
There was a problem hiding this comment.
why not do those inject from the invokeSnap function? i guess when force deploy/upgrade, u still need that? or no
khanti42
changed the base branch from
feat/enable-multiple-accounts
to
staging-force-cairo0-cairo1-capability
|
|
|
Already deployed to staging can be closed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR enhances the Snap by introducing support for multiple account discovery strategies within the same version, now with an improved user interface for better usability. Users can specify the desired strategy via a URL parameter called accountDiscovery. Additionally, the interface dynamically updates to highlight the selected strategy and provides a more user-friendly way to switch between options.
Key Features:
See the video below for an example
Screen.Recording.2025-01-22.at.21.46.58.mov