feat: Add RPC starkNet_toggleAccountVisibility to toggle the account visibility
#494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stanleyyconsensys
requested review from
Julink-eth and
jonesho
and removed request for
a team
Base automatically changed from
chore/unblock-account-create-limit
to
feat/enable-multiple-accounts
January 27, 2025 01:27
|
|
stanleyyconsensys
merged commit 492e311
into
feat/enable-multiple-accounts
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is add a new RPC
starkNet_toggleAccountVisibilityto toggle the account visibilityChanges:
starkNet_toggleAccountVisibilityand allowlist from the permission (restricted)removedAccountsrelated codeAccountService, we can pass a json data into theAccountobject, hence it can store it when reflect the correct data when usingserialize