Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect switch account RPC endpoint in Wallet-UI #496

Conversation

stanleyyconsensys
Copy link
Collaborator

This PR is to fix the incorrect switch account RPC endpoint in Wallet-UI

Change:

  • Update switch account RPC endpoint to starkNet_switchAccount
  • Remove duplicate initWalletData when adding a new account
  • Disable InfoModal temporarily

@stanleyyconsensys stanleyyconsensys requested a review from a team as a code owner January 24, 2025 03:26
@stanleyyconsensys stanleyyconsensys requested review from Julink-eth and wantedsystem and removed request for a team January 24, 2025 03:26
@stanleyyconsensys stanleyyconsensys changed the title fixL: incorrect switch account RPC endpoint in Wallet-UI fix: incorrect switch account RPC endpoint in Wallet-UI Jan 24, 2025
Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
4.4% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
17 New issues
0 Accepted issues

Measures
0 Security Hotspots
2.0% Coverage on New Code
0.6% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@khanti42 khanti42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@stanleyyconsensys stanleyyconsensys merged commit ac5e50a into feat/enable-multiple-accounts Jan 27, 2025
14 of 15 checks passed
@stanleyyconsensys stanleyyconsensys deleted the fix/incorrect-rpc-endpoint-in-wallet-ui branch January 27, 2025 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants