Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: wallet UI remove redundant condition check #500

Merged
merged 22 commits into from
Feb 4, 2025

Conversation

khanti42
Copy link
Collaborator

@khanti42 khanti42 commented Jan 28, 2025

This PR is to remove a redundant condition check with translate on wallet UI

@khanti42 khanti42 requested a review from a team as a code owner January 28, 2025 15:09
@khanti42 khanti42 requested review from Julink-eth and jonesho and removed request for a team January 28, 2025 15:09
@stanleyyconsensys stanleyyconsensys changed the title chore: wallet UI translation remove translate function check chore: wallet UI remove redundant condition check Jan 31, 2025
Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks like the PR is not ready

@stanleyyconsensys stanleyyconsensys marked this pull request as draft January 31, 2025 05:01
@khanti42 khanti42 force-pushed the fix/wallet-ui-translation branch from 3f10f9d to 1d18f59 Compare February 3, 2025 20:42
@khanti42 khanti42 marked this pull request as ready for review February 3, 2025 20:46
Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link

sonarqubecloud bot commented Feb 3, 2025

Quality Gate Passed Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Copy link
Collaborator

@stanleyyconsensys stanleyyconsensys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanti42 khanti42 added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 6921c85 Feb 4, 2025
14 checks passed
@khanti42 khanti42 deleted the fix/wallet-ui-translation branch February 4, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants