-
Notifications
You must be signed in to change notification settings - Fork 358
Add logic on ReqResp handlers for sidecar reconstruction #10153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add logic on ReqResp handlers for sidecar reconstruction #10153
Conversation
...ys/teku/networking/eth2/rpc/beaconchain/methods/DataColumnSidecarsByRangeMessageHandler.java
Show resolved
Hide resolved
| }; | ||
|
|
||
| SafeFuture<Optional<DataColumnSidecar>> reconstructDataColumnSidecar( | ||
| SignedBeaconBlock block, UInt64 index, Bytes32 requestHash); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| }; | ||
|
|
||
| SafeFuture<Optional<DataColumnSidecar>> reconstructDataColumnSidecar( | ||
| SignedBeaconBlock block, UInt64 index, Bytes32 requestHash); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| }; | ||
|
|
||
| SafeFuture<Optional<DataColumnSidecar>> reconstructDataColumnSidecar( | ||
| SignedBeaconBlock block, UInt64 index, Bytes32 requestHash); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| SafeFuture<Optional<DataColumnSidecar>> reconstructDataColumnSidecar( | ||
| SignedBeaconBlock block, UInt64 index, Bytes32 requestHash); | ||
|
|
||
| boolean isSidecarPruned(UInt64 slot, UInt64 index); |
Check notice
Code scanning / CodeQL
Useless parameter Note
| SafeFuture<Optional<DataColumnSidecar>> reconstructDataColumnSidecar( | ||
| SignedBeaconBlock block, UInt64 index, Bytes32 requestHash); | ||
|
|
||
| boolean isSidecarPruned(UInt64 slot, UInt64 index); |
Check notice
Code scanning / CodeQL
Useless parameter Note
|
|
||
| boolean isSidecarPruned(UInt64 slot, UInt64 index); | ||
|
|
||
| void onRequestCompleted(Bytes32 requestHash); |
Check notice
Code scanning / CodeQL
Useless parameter Note
PR Description
Add logic on handlers size for reconstruction of sidecars from proofs on supernodes.
This PR includes:
It's part of #10095
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Adds archive-backed reconstruction to DataColumnSidecars Req/Resp handlers and introduces a configurable sidecar retention window for supernodes.
DataColumnSidecarArchiveReconstructorand wire it throughEth2P2PNetworkBuilder→Eth2PeerManager→BeaconChainMethodsintoDataColumnSidecarsByRoot/ByRangehandlers.ResponseCallbackwithalwaysRun; implement inRpcResponseCallbackandLoggingResponseCallbackto notify reconstructor on request completion.DEFAULT_DATA_COLUMN_SIDECAR_EXTENSION_RETENTION_EPOCHSwith builder/getter and CLI flag--Xdata-column-sidecar-extension-retention-epochs.BeaconChainController(currentlyNOOP).RpcResponseCallbackTest, by-root/by-range handler tests, wiring in factories/managers).Written by Cursor Bugbot for commit fa7d5ae. This will update automatically on new commits. Configure here.