Return a result object instead of void when publishing execution payload #10158
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Return
PublishSignedExecutionPayloadResultinstead ofVoid. Also only imports execution payload if gossip validation passes (which should have been the logic from the start and it is per current PR specs ethereum/beacon-APIs#552)Also small changes to clean ForkChoice slightly
Fixed Issue(s)
N/A
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog
Note
Return a structured result when publishing execution payloads and only publish after successful gossip validation/import, with supporting store and fork-choice updates.
publishSignedExecutionPayload(inValidatorApiChannel,BuilderApiChannel, sentry/failover/metrics adapters) to returnPublishSignedExecutionPayloadResultinstead ofVoid.validator/api/PublishSignedExecutionPayloadResult.ExecutionPayloadPublisherto return the same result; adjust NOOP.ExecutionPayloadPublisherGloas, callExecutionPayloadManager.validateAndImportExecutionPayloadand publish payload/sidecars only onACCEPT; otherwise return rejected with reason.ValidatorApiHandlermaps exceptions to rejected results.SignedExecutionPayloadEnvelope.getBeaconBlockRoot()and use it in logs.MutableStore.putExecutionPayloadAndState; implement in test store; stub inStoreTransaction.ForkChoiceUtil/ForkChoiceUtilGloas: add availability checker overload for execution payloads and store execution payloads; useNOOP_DATACOLUMN_SIDECARfor Gloas.DefaultExecutionPayloadManager: remove separate import method; validate then import async; cache seen roots; improved logging.ChainBuilderand other callers switch togetBeaconBlockRoot().Written by Cursor Bugbot for commit 69a6a91. This will update automatically on new commits. Configure here.