[WIP] Unify BlobSidecar and Fulu trackers pruning using BlobTrackerPool #10215
+325
−183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...etransition/src/main/java/tech/pegasys/teku/statetransition/datacolumns/DasSamplerBasic.java
Fixed
Show fixed
Hide fixed
...c/main/java/tech/pegasys/teku/statetransition/datacolumns/PrunedDataAvailabilitySampler.java
Fixed
Show fixed
Hide fixed
tbenr
reviewed
Dec 9, 2025
| import tech.pegasys.teku.spec.datastructures.blocks.SignedBeaconBlock; | ||
| import tech.pegasys.teku.spec.datastructures.blocks.SlotAndBlockRoot; | ||
|
|
||
| public interface BlockPrunedTrackerFactory { |
Contributor
There was a problem hiding this comment.
what about naming it like DataSidecarBlockNotification or something similar. To signal that class implementing this will receive block notification for Data sidecar purposes.
tbenr
reviewed
Dec 9, 2025
| import tech.pegasys.teku.statetransition.blobs.BlockPrunedTrackerFactory; | ||
| import tech.pegasys.teku.statetransition.blobs.RemoteOrigin; | ||
|
|
||
| public interface PrunedDataAvailabilitySampler |
Contributor
There was a problem hiding this comment.
What about letting DasSampler implementing the interface directly, without having this intermediate? I feel like we already have too many :)
Contributor
Author
There was a problem hiding this comment.
It's definitely not in the scope of data availability sampling, but I agree with you that we already have too many interfaces. Let's clean up
tbenr
reviewed
Dec 9, 2025
| } | ||
|
|
||
| @Override | ||
| public void onSlot(final UInt64 slot) { |
Contributor
There was a problem hiding this comment.
we probably still need something pruning on finalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog