Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add schema registry in schema definitions #8615

Merged

Conversation

tbenr
Copy link
Contributor

@tbenr tbenr commented Sep 18, 2024

Adds the registry building in SpecVersion and provides registry in schemaDefinitions

It shares schemaRegistryBuilder among milestones creations (when possible) so that the global cache is shared and non-changing schemas will maintain the same instance cross-milestones

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@tbenr tbenr force-pushed the add-schema-registry-in-schema-definitions branch from 39e9961 to a8ad977 Compare September 18, 2024 16:16
@tbenr tbenr force-pushed the add-schema-registry-in-schema-definitions branch from a8ad977 to bd1f60c Compare September 24, 2024 09:17
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tbenr tbenr enabled auto-merge (squash) September 27, 2024 12:28
@tbenr tbenr merged commit 3064bc9 into Consensys:master Sep 27, 2024
17 checks passed
@tbenr tbenr deleted the add-schema-registry-in-schema-definitions branch September 27, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants