Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check network on start and reset db #8642

Merged
merged 31 commits into from
Oct 8, 2024
Merged

Check network on start and reset db #8642

merged 31 commits into from
Oct 8, 2024
+255 −2

Conversation

gconnect
Copy link
Contributor

@gconnect gconnect commented Sep 24, 2024 •
edited
Loading

PR Description

  • Check if the network is Ephemery and due for an update then reset the db.

Fixed Issue(s)

fixes #8589

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@gconnect
Copy link
Contributor Author

@rolfyone please review when you have the time. Thanks!

@gconnect gconnect changed the title Check network on start Check network on start and reset db Sep 24, 2024
@rolfyone
Copy link
Contributor

I'm not sure that's really at the right point currently, because we're leaking that deposit check in multiple places, and theres public functions that can delete folders etc, so i think we really need to think about how it all fits together... this feels very confused...

Are you able to have a look at how we might do this neatly? otherwise we can find a little time to get some design thought out so its relatively clean...

@gconnect
Copy link
Contributor Author

I'm not sure that's really at the right point currently, because we're leaking that deposit check in multiple places, and theres public functions that can delete folders etc, so i think we really need to think about how it all fits together... this feels very confused...

Are you able to have a look at how we might do this neatly? otherwise we can find a little time to get some design thought out so its relatively clean...

Thanks for reviewing. I will dive deeper and see how I can make the code better.

rolfyone
rolfyone reviewed Sep 30, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're getting there for sure! Hope the latest comments help!

services/chainstorage/src/main/java/tech/pegasys/teku/services/chainstorage/StorageService.java Outdated Show resolved Hide resolved
services/chainstorage/src/main/java/tech/pegasys/teku/services/chainstorage/StorageService.java Outdated Show resolved Hide resolved
services/chainstorage/src/main/java/tech/pegasys/teku/services/chainstorage/StorageService.java Outdated Show resolved Hide resolved
@gconnect
Copy link
Contributor Author

gconnect commented Oct 1, 2024

@rolfyone I have added some test please review and let me know what you think.

rolfyone
rolfyone approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your patience, looks better now. will move towards merging.

@rolfyone rolfyone merged commit 28d559b into Consensys:master Oct 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gconnect @rolfyone