Simplify schema provider definition #8829
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the need to specify
constant
orvariable
schema provider when defining them via builder.With this PR the non-changing instance across multiple forks is automatically guaranteed via an equality check.
This approach provide a nice benefit: you don't need to care about if the schema is changing or not. If the shema is an "high order" schema that looks up in the registry to pick the schemas for the fields, you don't know if those fields are changing across forks. This way we can be sure that we will always keep the new one whenever the new schema is semantically different from the previous one.
There are some edge cases in which the equality check may not do what we want (maybe?) so I provided a way to disable it.
Documentation
doc-change-required
label to this PR if updates are required.Changelog