-
Notifications
You must be signed in to change notification settings - Fork 331
Make various small fixes for Fulu code #9662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hmm I added |
networking/eth2/src/main/java/tech/pegasys/teku/networking/eth2/peers/DefaultEth2Peer.java
Outdated
Show resolved
Hide resolved
.../pegasys/teku/networking/eth2/gossip/subnets/NodeIdToDataColumnSidecarSubnetsCalculator.java
Outdated
Show resolved
Hide resolved
} else { | ||
calculatorAtSlot = NOOP; | ||
SpecVersion version = spec.atSlot(slot); | ||
if (version.getMilestone().isGreaterThanOrEqualTo(SpecMilestone.FULU)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this stuff should be exposed via SpecLogic
and we should remove those "if milestone is fulu".
But this can be for another PR
PR Description
throttling-dataColumn
tothrottling-columns
dataColumns
if desired.blobsCellBundle.getProofs()
in builder flow.blobSidecarsAvailabilityDeprecationSlot
toblobSidecarsDeprecationSlot
.computeDataColumnSidecarBackboneSubnets
.Documentation
doc-change-required
label to this PR if updates are required.Changelog