Skip to content

Make various small fixes for Fulu code #9662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Jul 15, 2025
Merged

Make various small fixes for Fulu code #9662

merged 15 commits into from
Jul 15, 2025

Conversation

jtraglia
Copy link
Contributor

PR Description

  • In strings, change several instances of "FULU" to "Fulu"
    • This is more consistent with other forks.
  • Rename throttling-dataColumn to throttling-columns
    • It should have been plural to match other keys.
    • Can rename to dataColumns if desired.
  • Add missing length check for blobsCellBundle.getProofs() in builder flow.
    • We checked this in Deneb, should probably check here too.
  • Rename blobSidecarsAvailabilityDeprecationSlot to blobSidecarsDeprecationSlot.
    • I found this function name to be misleading. I thought you were going to drop blobs at this slot.
  • Remove an unused parameter in computeDataColumnSidecarBackboneSubnets.
    • Did you intend to use this?

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@jtraglia
Copy link
Contributor Author

jtraglia commented Jul 14, 2025

Hmm I added @SuppressWarnings("UnusedVariable") to NodeIdToDataColumnSidecarSubnetsCalculator#createAtSlot because I didn't want to do a large refactor there. I don't really understand why this needs to be for a specific slot.

cursor[bot]

This comment was marked as outdated.

} else {
calculatorAtSlot = NOOP;
SpecVersion version = spec.atSlot(slot);
if (version.getMilestone().isGreaterThanOrEqualTo(SpecMilestone.FULU)) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this stuff should be exposed via SpecLogic and we should remove those "if milestone is fulu".
But this can be for another PR

@tbenr tbenr enabled auto-merge (squash) July 15, 2025 19:40
@tbenr tbenr merged commit 97d4d1b into Consensys:master Jul 15, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants