Skip to content

Simplify generate*RangeRequests for data columns #9667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 16, 2025
Merged

Simplify generate*RangeRequests for data columns #9667

merged 2 commits into from
Jul 16, 2025
+3 −16

Conversation

jtraglia
Copy link
Contributor

PR Description

The computeIfAbsent method can make these simpler.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

lucassaldanha
lucassaldanha approved these changes Jul 16, 2025
View reviewed changes
Copy link
Member

@lucassaldanha lucassaldanha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha enabled auto-merge (squash) July 16, 2025 01:57
@lucassaldanha lucassaldanha merged commit 25b43b3 into Consensys:master Jul 16, 2025
17 checks passed
@jtraglia jtraglia deleted the simplify-requests branch July 16, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucassaldanha lucassaldanha lucassaldanha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jtraglia @lucassaldanha