-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Azure secp bulk loading #850
Conversation
… used in the test. And remove multiple signing test as this doesn't add any value
…e key in BLS mode
…xecutorService if doesn't already exist
keystorage/src/test/java/tech/pegasys/web3signer/keystorage/azure/AzureKeyVaultTest.java
Dismissed
Show dismissed
Hide dismissed
…st works with AT ThreadRunner
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Fixed
Show fixed
Hide fixed
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good test coverage 👍
Just some nits really.
...ests/src/test/java/tech/pegasys/web3signer/tests/slashing/SlashingPruningAcceptanceTest.java
Show resolved
Hide resolved
commandline/src/main/java/tech/pegasys/web3signer/commandline/subcommands/ModeSubCommand.java
Show resolved
Hide resolved
core/src/main/java/tech/pegasys/web3signer/core/Eth1Runner.java
Outdated
Show resolved
Hide resolved
signing/src/main/java/tech/pegasys/web3signer/signing/config/SignerLoader.java
Outdated
Show resolved
Hide resolved
signing/src/main/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactory.java
Show resolved
Hide resolved
return executorServiceCache.updateAndGet( | ||
e -> | ||
Objects.requireNonNullElseGet( | ||
e, () -> Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()))); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit/musing: could potentially simplify by using a ConcurrentHashMap, but with the downside of a redundant key name. Don't think it's worth it, was just an interesting pattern to review...
return executorServiceCache.computeIfAbsent(
"key",
e -> Executors.newFixedThreadPool(Runtime.getRuntime().availableProcessors()));
signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/azure/AzureKeyVaultSigner.java
Show resolved
Hide resolved
signing/src/test/java/tech/pegasys/web3signer/signing/config/AzureKeyVaultFactoryTest.java
Dismissed
Show dismissed
Hide dismissed
...sts/src/test/java/tech/pegasys/web3signer/dsl/signer/runner/CmdLineParamsConfigFileImpl.java
Show resolved
Hide resolved
...sts/src/test/java/tech/pegasys/web3signer/tests/bulkloading/AzureKeyVaultAcceptanceTest.java
Show resolved
Hide resolved
core/src/main/java/tech/pegasys/web3signer/core/Eth1Runner.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some nits, otherwise lgtm
signing/src/main/java/tech/pegasys/web3signer/signing/secp256k1/azure/AzureConfig.java
Outdated
Show resolved
Hide resolved
...g/src/test/java/tech/pegasys/web3signer/signing/secp256k1/azure/AzureKeyVaultSignerTest.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Runners are much more comprehensible now 👍
PR Description
Add bulk loading of secp keys to the eth1 mode of Web3Signer.
This adds the following new command line options to web3signer eth1 subcommand:
Changes
Fixed Issue(s)
fixes #832
Documentation
doc-change-required
label to this PR if updates are required.Changelog
Testing