Skip to content

Conversation

@divyanshsingh101
Copy link

@divyanshsingh101 divyanshsingh101 commented Oct 12, 2024

added a rating feature

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.

Related Issue

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Motivation and Context

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Screenshots (if appropriate):

Screenshot 2024-10-12 162741
Screenshot 2024-10-12 162755
Screenshot 2024-10-12 162810

Checklist:

  • I have registered myself at Contrihub website.
  • My code follows the code style of this project.
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • Any dependent changes have been merged and published in downstream modules
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

@eleensmathew
Copy link
Collaborator

Hey can you resolve the conflicts?

@eleensmathew
Copy link
Collaborator

Attach screenshots with an example movie

@divyanshsingh101
Copy link
Author

added it

@eleensmathew
Copy link
Collaborator

eleensmathew commented Oct 12, 2024

Hey are you showing the average of all user ratings in the user ratings?
If you are confused it must be like:
1 - imdb star rating
2 - avg user rratings
3 - user selects ratings
Use these titles under the stars

@divyanshsingh101
Copy link
Author

no as there is no session as of now same user can add multiple rating so i need to take avg of all ratings then display the rating ?
and should the add rating slider be on the same page ?

@divyanshsingh101
Copy link
Author

what is user selects rating ?

@eleensmathew
Copy link
Collaborator

no as there is no session as of now same user can add multiple rating so i need to take avg of all ratings then display the rating ? and should the add rating slider be on the same page ?

Yes and yes

@eleensmathew
Copy link
Collaborator

what is user selects rating ?

its basically the add ratings slider

@divyanshsingh101
Copy link
Author

divyanshsingh101 commented Oct 12, 2024

how much time do i have as i have to change the features allot :( ?

@eleensmathew
Copy link
Collaborator

how much time do i have as i have to change the features allot :( ?

Just submit this pr in the website and take as much time as you need to complete it.

@eleensmathew
Copy link
Collaborator

Have you made the requested changes? If not close this pr

@eleensmathew
Copy link
Collaborator

Someone else has also fix this issue. I will pull her changes in the meantime you can update your code and overwrite the changes made by the other pr

@divyanshsingh101
Copy link
Author

Sorry ma'am I couldn't do the changes as I am hospitalized from 2 days as I have been diagnosed with dengue and typhoid

@eleensmathew
Copy link
Collaborator

Oh ok np. Hope you get well soon then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants