feat: implement QR code API route with session ID generation #344
+148
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gobengo
reviewed
Apr 16, 2025
app/api/lcw/qr-code/route.ts
Outdated
| // In-memory token store, replace with Redis? | ||
| const SESSION_TOKENS = new Map() | ||
|
|
||
| const JWT_SECRET = process.env.JWT_SECRET || 'RANDOE_SECRET_KEY' |
There was a problem hiding this comment.
this will get created on each evaluation of this module, which might mean the sessions are not persisted across separate invocations of the route.
It might work better if you move this map instance to another module. then i think all imports of the Map will get the same instance
There was a problem hiding this comment.
yeah i will just create a single API route like /api/lcw/[request].ts and handling different types of requests based on the [request] param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.